Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/remove custom service type no custom type hash #1264

Conversation

NicolasMahe
Copy link
Member

Dependant on #1263
Will merge to #1260

Remove the custom type define for the service.hash so the hash is still send as plain string on the API.

@NicolasMahe NicolasMahe added this to the next milestone Aug 28, 2019
@NicolasMahe NicolasMahe self-assigned this Aug 28, 2019
@NicolasMahe NicolasMahe changed the base branch from dev to refactor/remove-custom-service-type August 28, 2019 09:55
@NicolasMahe NicolasMahe force-pushed the refactor/remove-custom-service-type-no-custom-type-hash branch from 342bcf9 to 281dd92 Compare August 28, 2019 10:04
@krhubert krhubert merged commit 281dd92 into refactor/remove-custom-service-type Aug 28, 2019
@krhubert krhubert deleted the refactor/remove-custom-service-type-no-custom-type-hash branch August 28, 2019 10:10
@NicolasMahe NicolasMahe added release:change Pull requests that change something existant and removed waiting dependent pr labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring release:change Pull requests that change something existant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants