Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hash.Hash type in service proto definition #1272

Merged

Conversation

krhubert
Copy link
Contributor

No description provided.

hash/hash.go Outdated Show resolved Hide resolved
@NicolasMahe
Copy link
Member

@krhubert please provide description and metadata even if this PR will be merge into another one. I didn't see this a first glance.

@krhubert
Copy link
Contributor Author

@krhubert please provide description and metadata even if this PR will be merge into another one. I didn't see this a first glance.

The full description is in the title. I don't know what more needs to be wrote here. And I don't understand about what metadata are you talking about?

@antho1404
Copy link
Member

antho1404 commented Aug 30, 2019

the labels/project/milestone etc...
Also, you can add in the description of how we can test that

@krhubert
Copy link
Contributor Author

the labels/project/milestone etc...

I thought that pr that are merge to non-dev branch dosen't have to have all such stuff.

Also, you can add in the description of how we can test that

Do we really want to waste time to write such obvious thing how to test change of API? Everyone knows how to test it...

@NicolasMahe NicolasMahe merged commit e283171 into refactor/hash-string-to-bytes Aug 30, 2019
@NicolasMahe NicolasMahe deleted the refactor/servcie-proto-hash-type branch September 4, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants