Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace instance struct with protobuf #1293

Merged
merged 7 commits into from
Sep 3, 2019
Merged

Replace instance struct with protobuf #1293

merged 7 commits into from
Sep 3, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented Sep 2, 2019

Dep #1292
Fix #1280

@krhubert krhubert self-assigned this Sep 2, 2019
@krhubert krhubert added this to the next milestone Sep 2, 2019
@krhubert krhubert requested review from antho1404 and NicolasMahe and removed request for antho1404 September 2, 2019 17:08
@NicolasMahe NicolasMahe merged commit f576ae3 into dev Sep 3, 2019
@NicolasMahe NicolasMahe deleted the refactor/remove-instance branch September 3, 2019 08:17
@NicolasMahe NicolasMahe mentioned this pull request Sep 3, 2019
Merged
@NicolasMahe NicolasMahe added release:change Pull requests that change something existant and removed waiting dependent pr labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees

@krhubert krhubert

Labels
refactoring release:change Pull requests that change something existant
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Use proto generated struct for Instances
3 participants
@krhubert @antho1404 @NicolasMahe