Remove and refactor rest protobuf types #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
force-pushed
the
refactor/drop-rest-custom-types
branch
2 times, most recently
from
d38180a
to
fc94bff
Compare
antho1404
reviewed
Sep 3, 2019
- remove filter and condition types - move filter tests to process - replace process type - replace event type - replace execution type - add missing hash and validation tags - fix hash tags - lint
krhubert
force-pushed
the
refactor/drop-rest-custom-types
branch
from
fc94bff
to
23a72fc
Compare
|
I've tested all service commands and found that service:logs dosent' work, @antho1404 can you confrim it? |
NicolasMahe
reviewed
Sep 4, 2019
| return err | ||
| } | ||
| } | ||
| warnings, err := s.ValidateTaskInputs(taskKey, in) |
There was a problem hiding this comment.
will it be possible to update the function ValidateTaskInputs and co to accept directly *types.Struct?
There was a problem hiding this comment.
I guess it will be possible and maybe even better for the type casting as struct.Value seems to already manage type.
yeah logs is broken.. but it is not because of this PR. it doesn't work on dev branch as well. i will investigate. Fixed in mesg-foundation/cli#148. Otherwise this PR is working well. I'm approving 👍 |
NicolasMahe
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1283
close #1282
close #1281