Run scripts from Makefile #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antho1404
reviewed
Oct 10, 2019
krhubert
force-pushed
the
refactor/makefile
branch
2 times, most recently
from
b5aab9e
to
6061242
Compare
- craete Makefile - remove mesg-tools and require-mesg-tools scripts - move build-engine to Dockerfile - remove go-bindata from Dockefile.tools - require changelog arg - remove Dockerfile.dev - move dev to scripts dir
krhubert
force-pushed
the
refactor/makefile
branch
from
6061242
to
a4aec86
Compare
antho1404
reviewed
Oct 12, 2019
NicolasMahe
reviewed
Oct 21, 2019
NicolasMahe
reviewed
Oct 21, 2019
NicolasMahe
reviewed
Oct 21, 2019
antho1404
approved these changes
Oct 21, 2019
Codecov Report
@@ Coverage Diff @@
## dev #1402 +/- ##
=======================================
Coverage 62.94% 62.94%
=======================================
Files 41 41
Lines 1773 1773
=======================================
Hits 1116 1116
Misses 558 558
Partials 99 99Continue to review full report at Codecov.
|
NicolasMahe
reviewed
Oct 22, 2019
NicolasMahe
reviewed
Oct 22, 2019
NicolasMahe
reviewed
Oct 22, 2019
NicolasMahe
reviewed
Oct 22, 2019
NicolasMahe
reviewed
Oct 22, 2019
Move advance version tagging from makefile to circleci
Co-Authored-By: Nicolas Mahé <nicolas@mesg.com>
NicolasMahe
approved these changes
Oct 22, 2019
NicolasMahe
reviewed
Oct 22, 2019
| fi | ||
|
|
||
| # create mesg data folder on host machine | ||
| mkdir -p $MESG_PATH |
krhubert
force-pushed
the
refactor/makefile
branch
from
b978bb6
to
cb674d0
Compare
NicolasMahe
added
the
release:change
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1393
TODO: There is no option to pass an argument to dev script right now. I need to figure it out, but it will be done with YAML config update.
I think everything now is in Makefile and it's a lot cleaner