-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify txbuilder and improve keybase signing #1627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the management of the cache for the private key.
- The delay might be unnecessary for now
- The management of the
lastSign
is not clear. We should support have a map to cache all of them or none of them.
…his impressively improve the performance.
edbd8bb
to
6390e18
Compare
I remove the cache based on time in favour of a cache using a map to store all private keys used. The index of the map is the sha256 checksum of the account's name and password. Performance comparison with the e2e tests 🍾 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the actual performance improvement with some metrics like #1570 (comment) to really see the impact of it ;)
Here is the result before and after with the monitoring metrics: after: @antho1404 check again now we have the dashboard in place! |
This PR remove the custom TxBuilder that we have in favour of using the default one directly.
The custom keybase signing has been re-implemented to add a cache on the plain private key of the user. This impressively improves the performance! The engine can sign 1,000 of txs in less than 1 sec (before only around 3 or 4 per sec)
Related to #1570
Next step is to investigate mempool issue by running the monitoring tool