-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min price for execution #1691
Conversation
Why this should be set globally? I think that value should be set by service creator (or even voting by service creator and runners). What do you think? |
Totally agree that the service creator/runner should set the price, this is just a min value that can later be set to 0 if necessary but the main goal here is to be able to actually see this economy. For now, everything is ready for it but we still accept free executions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you test to change the parameter on a running blockchain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about also putting the var runnerShare = sdk.NewDecWithPrec(9, 1)
in params?
Co-Authored-By: Nicolas Mahé <nicolas@mesg.com>
Didn't want to change this on this PR but yes definitely something that we could add later. |
The errors are pretty bad:
from the engine's logs
we really need to improve the returned error but not blocking for this PR |
Right now an execution can be created with 0 tokens.
I added the support of a minimum that is set for now to
10000atto
. This parameter is part of the module and present in the genesis.I also added a config to have a default price from the clients (api/orchestrator)
The good thing of having this parameter in the genesis is that we could do some vote to change this limit and we can play with proposal/votes.