Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace runner gRPC by LCD in e2e tests #1757

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Conversation

NicolasMahe
Copy link
Member

Dependent on #1751
Related to #1741

  • fix bug runner/builder/container when current UID and GID are not 0
  • Introduce a new structure runner/builderLCD that create and stop docker services and returns the msg to broadcast.
  • Use it in e2e tests.
  • Remove gRPC RunnerClient from e2e test.

@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Mar 27, 2020
@NicolasMahe NicolasMahe added this to the next milestone Mar 27, 2020
@NicolasMahe NicolasMahe self-assigned this Mar 27, 2020
e2e/runner_test.go Outdated Show resolved Hide resolved
e2e/runner_test.go Outdated Show resolved Hide resolved
runner/builder/builder_lcd.go Outdated Show resolved Hide resolved
runner/builder/builder_lcd.go Outdated Show resolved Hide resolved
@antho1404 antho1404 merged commit b97f4e4 into dev Mar 27, 2020
@antho1404 antho1404 deleted the feature/e2e-lcd-runner branch March 27, 2020 18:06
@NicolasMahe NicolasMahe mentioned this pull request Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:change Pull requests that change something existant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants