Add cli dockerfile #1808
Merged
Add cli dockerfile #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
commented
May 5, 2020
| @@ -61,6 +61,9 @@ build-cmd: dep | |||
| go build -mod=readonly -o ./bin/mesg-cli ./cmd/mesg-cli/ | |||
| go build -mod=readonly -o ./bin/mesg-daemon ./cmd/mesg-daemon/ | |||
|
|
|||
| build-docker-cli: check-version | |||
| docker build -t mesg/engine:cli -f ./Dockerfile.cli --build-arg version=$(version) . | |||
There was a problem hiding this comment.
mesg/engine:cli is a temp image tag. it will be replaced in following PR
NicolasMahe
commented
May 5, 2020
| @@ -1,5 +1,5 @@ | |||
| # base Go image version. | |||
| FROM golang:1.13.0-stretch | |||
| FROM golang:1.13.10 | |||
There was a problem hiding this comment.
updated this in order to use the same base image in all future dockerfile
NicolasMahe
commented
May 5, 2020
antho1404
approved these changes
May 5, 2020
| # ubuntu image with binaries for distribution | ||
| FROM ubuntu:18.04 | ||
| RUN apt-get update && \ | ||
| apt-get install -y --no-install-recommends ca-certificates=20180409 && \ |
There was a problem hiding this comment.
do we still need this install? If I remember correctly it was related to the fetch from git that we had but we don't have this anymore.
There was a problem hiding this comment.
I think it's good to install the ca certificates to verify SSL connection.
User could setup a SSL remote connection to another peer or to a RPC endpoint?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Dockerfile that compiles and exposes the 2 clis.
The default dockerfile cmd is using only on cli, but the otherone can still be usable by overriding the default cmd when starting the container.