Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker container in e2e tests #1817

Merged
merged 3 commits into from
May 11, 2020
Merged

Conversation

NicolasMahe
Copy link
Member

Update e2e test to use docker container instead of docker service

@NicolasMahe NicolasMahe self-assigned this May 8, 2020
@NicolasMahe NicolasMahe requested a review from antho1404 May 8, 2020 10:04
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label May 8, 2020
@NicolasMahe NicolasMahe added this to the next milestone May 8, 2020
@NicolasMahe NicolasMahe force-pushed the feature/e2e-docker-container branch from b84a6c4 to 6db5231 Compare May 8, 2020 10:15
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

container/container.go Show resolved Hide resolved
@NicolasMahe NicolasMahe merged commit 7345fe5 into dev May 11, 2020
@NicolasMahe NicolasMahe deleted the feature/e2e-docker-container branch May 11, 2020 08:17
@NicolasMahe NicolasMahe mentioned this pull request May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:change Pull requests that change something existant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants