Use docker volumes and not binding for services #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual system is using binding for services volumes. In our case we don't really need to bind the folder to a specific path on the host machine and this add a lot of complexity on the configuration of this docker container.
The docker socket sent to the core container is still using the
bind
mode but other volumes are now using the new default value from dockervolume
and notbind
anymore. This means that all the volumes that need to be mounted on a service will no longer be present in~/.mesg/services
but will be managed by docker.This will be helpful for the PR #416
fix #125