Start service dependencies one by one

[krhubert]

closes #382

[NicolasMahe]

What is the order of start?
Does the service start before the dependencies or the other way?

I would say it makes sense to start the dependencies first. (as the name suggest, the service is dependent on them).

[krhubert]

Before there was no order of starting. And it's the pbm because some dependencies may eg. connect to service and the other opposite, so it's hard to tell the one perfect order.

For example you deploy website as servcie and has db as a dependency so service must start first.

Second, you deploy database and eg. crawlers as a dependency in that case db must start first so crawler can connect to it

[NicolasMahe]

For info, the dependencies are started before the service itself. LGFM

[antho1404]

Why the dependencies are starting before the service ? This is just based on a map so it shouldn't by default, this needs to be added for me, I don't see how it can be done with the code here

[NicolasMahe]

Because of the way we inject the configuration to dependencies. See end of func deploy:
https://github.com/mesg-foundation/core/blob/fcea30b78145f1b27a3979555418560745a8186f/service/service.go#L193-L207

Actually, why are we keeping configuration if it copied to dependencies?
It could be copied to service way before, in service.injectDefinition:
https://github.com/mesg-foundation/core/blob/fcea30b78145f1b27a3979555418560745a8186f/service/inject_definition.go#L11-L26

Let's either remove configuration from service, or let's not copy config in dependencies.

see #624

[mesg-bot]

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/start-docker-services-in-parallel/144/1