Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated parameters #679

Merged
merged 10 commits into from
Jan 6, 2019
Merged

Repeated parameters #679

merged 10 commits into from
Jan 6, 2019

Conversation

NicolasMahe
Copy link
Member

Same PR as #678 that I merged by mistake.


Add support for repeated parameters + validation of the repeated parameters

Still use some reflection but only when it's repeated. If anyone have a simpler way to do it that would be great.

@NicolasMahe
Copy link
Member Author

NicolasMahe commented Jan 6, 2019

I created a other PR that improve this one: #680
We can use array casting (to []interface{}) rather than reflection.
I think, the problem was coming from test that are using []string types to test array validation.
I also change validation test to be based on JSON data rather than Go struct. That way, we don't choose any type, but let json.Unmarshal decide.

@NicolasMahe
Copy link
Member Author

I just merged #680 into this PR.
Please review and merge!

@krhubert krhubert merged commit 52ea03b into dev Jan 6, 2019
@ilgooz ilgooz deleted the feature/repeated-params branch January 6, 2019 19:37
@mesg-bot
Copy link
Member

This pull request has been mentioned on MESG Community. There might be relevant details there:

https://forum.mesg.com/t/add-more-detailed-data-in-the-mesg-yml/126/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants