Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendor #693

Merged
merged 8 commits into from
Jan 13, 2019
Merged

Remove vendor #693

merged 8 commits into from
Jan 13, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

@antho1404
Copy link
Member

It looks like we need to force the modules with go

go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'

@krhubert
Copy link
Contributor Author

Or move sources outside $GOPATH which is more preferable one by go

NicolasMahe
NicolasMahe requested changes Jan 13, 2019
View reviewed changes
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are failing.
Solve with #697

NicolasMahe
NicolasMahe previously approved these changes Jan 13, 2019
View reviewed changes
@krhubert krhubert merged commit 5cd80b0 into dev Jan 13, 2019
@ilgooz ilgooz deleted the feature/rm-vendor branch January 13, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krhubert @antho1404 @NicolasMahe @ilgooz