Deploy core services from tar #725
Conversation
antho1404
changed the title
…e-service-from-tar
antho1404
changed the title
|
Did you manage to setup a dev environment for deploying service from local computer? |
|
not yet created the tool for dev to deploy locally, this will be done in another PR |
There was a problem hiding this comment.
This is not complete at all and doing in fast.
- what the problem dose it solve?
Second in order to deploy service from URL we need to have mesg.yaml then we donwload second mesg.yaml
and which one should we take?
It introduces egg and chicken problem and no solution to it. What if mesg.yaml will have url and inside new service it will be diffretn url etc....
For me this PR need to rethink more corner cases
|
|
||
| return grpc.New(c.Server.Address, a), nil | ||
| } | ||
|
|
||
| func deployCoreServices(c *config.Config, api *api.API) error { |
There was a problem hiding this comment.
This logic shouldn't be in main.go
the url point directly to the source of the service, not to a mesg.yml |
NicolasMahe
changed the base branch from
feature/remove-system-services
to
dev
But the source will have proabably mesg.yml. If not then how we want to keep files:
So this simple change will have effect on how the developers distrubute services and sources. |
|
I don't understand your point, why do we need the yaml and the endpoint ? the yaml is inside the tarbal that will be downloaded with the tarball. Here we download the full tar (source + definitions) and deploy it when the core starts like that these services are available for the core and the core can use them. For now there is the |
|
@krhubert are you ok with this one, can we merge or is there still some part to clarify ? |
|
This PR is done her #737. |
This one depends on #724
Here we add services directly in the configs with a way to deploy them and when the core starts then all the services are automatically downloaded/deployed/started in order for the core to use them.