Use service id #734
Use service id #734
Conversation
There was a problem hiding this comment.
I think we should be using sid and hash together whenever possible and convert sid to service's latest deployed hash.
It should be possible to deploy/start/stop a specific version of the service by using hash. or when sid used, devs should know which version(hash) they're getting.
For example:
- while deploying a service with sid, we should both return sid and hash as a reply for successful deployments. Same applies to other commands(apis) as well.
- or when hash is used to deploy, again we should return both with the corresponding sid and this hash in the reply.
- we should use and return sid & hash in error types(NotRunningServiceError etc.) too.
|
I agree with @ilgooz about having both. For now we have a 1 to 1 relation between sid and hash but this will probably evolve in 1 to many and in that case the deploy needs to return the hash like that we can delete only the version of the hash. If there is no good reasons to change to sid I think we should not do it |
|
I agree with @ilgooz too, but this PR is about being consistent so when there is variable service id use sid. The next prs will add hash to api, database etc ... But here is the first simple step |
No description provided.