Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo + grama #763

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Typo + grama #763

merged 3 commits into from
Feb 1, 2019

Conversation

krhubert
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ilgooz
ilgooz previously approved these changes Jan 31, 2019
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some improvements too other than that, lgtm

Grama fixes

Co-Authored-By: krhubert <krhubert@gmail.com>
@@ -191,9 +191,9 @@ Check out the documentation for more information on [how to create tasks](https:

Services can also submit events to MESG Core. They allow two-way communication with MESG Core and Applications.

Let's say the service is a HTTP webserver. An event could be submitted when the webserver receives a request with the request's payload as the event's data. The service could also submit a specific event for every route of your API.
Let's say the service is an HTTP web server. An event could be submitted when the web server receives a request with the request's payload as the event's data. The service could also submit a specific event for every route of your HTTP API.
Copy link
Member

@NicolasMahe NicolasMahe Feb 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually i'm curious why "an http server"?

@NicolasMahe NicolasMahe changed the base branch from fix/readme to master February 1, 2019 05:55
@NicolasMahe NicolasMahe merged commit d445663 into master Feb 1, 2019
@NicolasMahe NicolasMahe deleted the fix/readme-2 branch February 1, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants