Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add marketplace service #797

Closed
wants to merge 47 commits into from
Closed

Add marketplace service #797

wants to merge 47 commits into from

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Mar 7, 2019 •
edited
Loading

No description provided.

@NicolasMahe
First commit marketplace service
63954a2
@NicolasMahe
wip marketplace
388d4d5
@NicolasMahe
WIP
c3ff783
@NicolasMahe
Add download of the metadata file
57ab20b
@NicolasMahe
add node_modules to gitignore
251fbdb
@NicolasMahe
WIP
01ef198
@NicolasMahe
npm update
ba1a731
@NicolasMahe
Rename sendSignedRawTx to sendSignedTransaction
0abd16f
@NicolasMahe
Update to match latest version of marketplace
9ac36c4
@NicolasMahe
Update to work on real blockchain
18f91eb
@NicolasMahe
Get serviceList task returns the list of services
3ff3399
@NicolasMahe
Implement IPFS
ea0a618
@NicolasMahe
Improve get manifest function
cacfea2
@NicolasMahe
Add task that modify the state
0092334
@NicolasMahe
add isAuthorized task
a8787f1
@NicolasMahe
WIP add event serviceCreated
c0f2f59
@NicolasMahe
Set web3 to beta37. Fix marketplace service codebase.
69431cc
@NicolasMahe
Add all event but need to convert in ascii hexa encoded values
8517651
@NicolasMahe
add hexToAscii conversion on event
18642d0
@NicolasMahe
Update to match latest version of smart contract
766f59d
@NicolasMahe
Update test data to match new smart contract
85c9a0b
@NicolasMahe
Update marketplace service to latest smart contract
1506c87
@NicolasMahe
Set data of transaction output to string
c348430
@NicolasMahe
Task that accepted sidHash now simply accept sid and sha3 hash it.
4498c51
@NicolasMahe
Add task getService and serviceExist. Improve non existing service/ve…
4e33873 
…rsion/offer/purchase management.
@NicolasMahe
Lowercase any hex
ad08bda
@NicolasMahe
Add task getServiceVersion
e48a31e
@NicolasMahe
Add task checkForDeployment that check if at list one address of a li…
7cb7ea4 
…st of address is authorized, and then return the service deployment source and type.
@NicolasMahe
Convert to and from unit all prices
4c8b467
@NicolasMahe
Update to latest release
5bb14c7
@NicolasMahe NicolasMahe mentioned this pull request Mar 7, 2019
Closed
@antho1404
Copy link
Member

  • The publishServiceVersion works fine, just some feedback on the API Simplify createServiceVersion api marketplace#15
  • sendSignedTransaction works great
  • The listServices task doesn't return anything
  • I got an error with the getService (maybe timeout: 10000 is too low, why even a specific timeout)
service |  error while downloading manifest  ipfs :: QmcVUzKw1YHwpHi7V3hEcigq4PXhw26wuEK2TDL6pC7NBP RequestError: Error: ESOCKETTIMEDOUT

Didn't test the other tasks but I think some are not necessary:

  • disableServiceOffer
  • transferServiceOwnership

Also some could be done directly on marketplace.mesg.com:

  • createServiceOffer
  • purchase
    This doesn't needs to be on the system service and can be done directly on the website with metamask and nice UI

@antho1404 antho1404 mentioned this pull request Mar 7, 2019
Closed
@NicolasMahe
Copy link
Member Author

NicolasMahe commented Mar 12, 2019 •
edited
Loading

Tasks disableServiceOffer and transferServiceOwnership removed

@NicolasMahe
Copy link
Member Author

Task listServices fixed

@NicolasMahe NicolasMahe changed the title Add marketplace core service Add marketplace service Mar 12, 2019
@NicolasMahe
Copy link
Member Author

closing in favor of #810

@NicolasMahe NicolasMahe deleted the ss/marketplace-simplified branch March 19, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antho1404 antho1404 Awaiting requested review from antho1404

@krhubert krhubert Awaiting requested review from krhubert

@ilgooz ilgooz Awaiting requested review from ilgooz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404