Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hash to reply of Deploy API #801

Merged
merged 6 commits into from
Mar 11, 2019
Merged

Add Hash to reply of Deploy API #801

merged 6 commits into from
Mar 11, 2019

Conversation

NicolasMahe
Copy link
Member

Needed for #798

@NicolasMahe NicolasMahe force-pushed the feature/deploy-return-hash branch from d40c193 to 252d2db Compare March 8, 2019 05:51
@NicolasMahe NicolasMahe force-pushed the feature/deploy-return-hash branch from 592df59 to 506bf9b Compare March 8, 2019 08:28
@NicolasMahe NicolasMahe requested a review from krhubert March 8, 2019 08:28
ilgooz
ilgooz previously approved these changes Mar 8, 2019
View reviewed changes
commands/service_deploy.go Outdated Show resolved Hide resolved
commands/service_dev.go Outdated Show resolved Hide resolved
antho1404
antho1404 reviewed Mar 8, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except few modifications everything looks good

@antho1404 @NicolasMahe
Update interface/grpc/core/deploy_integration_test.go
91fb4b1 
Co-Authored-By: NicolasMahe <nicolas@mahe.me>
antho1404 and others added 2 commits March 8, 2019 18:58
@antho1404 @NicolasMahe
Apply suggestions from code review
796d6e2 
Co-Authored-By: NicolasMahe <nicolas@mahe.me>
@ilgooz @NicolasMahe
Apply suggestions from code review
b1249a0 
Co-Authored-By: NicolasMahe <nicolas@mahe.me>
@NicolasMahe
Copy link
Member Author

@mesg-foundation/core modif done

@NicolasMahe NicolasMahe requested a review from ilgooz March 8, 2019 12:00
ilgooz
ilgooz previously approved these changes Mar 8, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual tests are OK.

@NicolasMahe
Copy link
Member Author

@mesg-foundation/core reserved keyword removed from proto and dev merged. please review.

@antho1404 antho1404 merged commit c5af6ca into dev Mar 11, 2019
@antho1404 antho1404 deleted the feature/deploy-return-hash branch March 11, 2019 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@antho1404 antho1404 antho1404 approved these changes

@krhubert krhubert Awaiting requested review from krhubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NicolasMahe @antho1404 @krhubert @ilgooz