Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop service in core main async #816

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Stop service in core main async #816

merged 1 commit into from
Mar 15, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Mar 15, 2019 •
edited
Loading

The stop service function on core stop is now async.
I leave it even if PR #815 also add it to command stop because of the following comment:

I also leave the removal of service in the Core in case the user delete remove the docker service Core manually, in this case, the core has 10sec to remove all services. That's not perfect, but should be enough if just 1 service is running.

ilgooz
ilgooz approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manual tests are ok

@ilgooz ilgooz merged commit 1136664 into dev Mar 15, 2019
@ilgooz ilgooz deleted the feature/stop-service-async branch March 15, 2019 12:15
This was referenced Mar 16, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@krhubert krhubert krhubert approved these changes

@antho1404 antho1404 Awaiting requested review from antho1404

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasMahe @krhubert @ilgooz