Add publish tasks to service marketplace #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
changed the title
antho1404
reviewed
Mar 30, 2019
# Conflicts: # systemservices/marketplace/src/contracts/utils.ts # systemservices/marketplace/src/events/index.ts # systemservices/marketplace/src/events/serviceCreated.ts # systemservices/marketplace/src/events/serviceOfferCreated.ts # systemservices/marketplace/src/events/serviceOfferDisabled.ts # systemservices/marketplace/src/events/serviceOwnershipTransferred.ts # systemservices/marketplace/src/events/servicePurchased.ts # systemservices/marketplace/src/events/serviceVersionCreated.ts # systemservices/marketplace/src/index.ts
antho1404
reviewed
Apr 3, 2019
|
@mesg-foundation/core this PR is ready to review |
antho1404
previously approved these changes
Apr 5, 2019
…error Remove unnecessary test on undefined value
antho1404
approved these changes
Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on #843
I created 3 task to replace the generic
sendSignTransaction. Each task return the decoded event from the receipt of the ethereum transaction. It means that the service output the data that has been added to ethereum.Eg:
Because there is no service composition yet, for example to create an offer, the user first needs to call
prepareCreateServiceOffer, then sign the transaction with the service ethwallet, and then callpublishCreateServiceOffer.