-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marketplace publish service raw data #845
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
afd2380
use raw data to send to the marketplace
antho1404 2fd1b29
Merge branch 'dev' into feature/marketplace-publish-service-raw-data
antho1404 9b65307
commit service definition on the marketplace
antho1404 91e07f8
Merge branch 'dev' into feature/marketplace-publish-service-raw-data
antho1404 05ba84e
remove wrong commit
antho1404 046f8d4
Merge branch 'dev' into feature/marketplace-publish-service-raw-data
NicolasMahe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
node_modules |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
FROM node:10.15 | ||
WORKDIR /app | ||
COPY ./package* ./ | ||
RUN npm install | ||
COPY . . | ||
CMD [ "node", "index.js" ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
const mesg = require('mesg-js').service() | ||
|
||
mesg.listenTask({ | ||
taskX: require('./tasks/taskX') | ||
}) | ||
.on('error', (error) => console.error(error)) | ||
|
||
mesg.emitEvent('started', { x: true }) | ||
.catch((error) => console.error(error)) | ||
|
||
console.log('gnarf gnarf') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: myservice | ||
sid: myservice | ||
description: "Description of my service" | ||
tasks: | ||
taskX: | ||
inputs: | ||
foo: | ||
type: String | ||
bar: | ||
type: String | ||
outputs: | ||
success: | ||
data: | ||
message: | ||
type: String | ||
error: | ||
data: | ||
error: | ||
type: String | ||
events: | ||
started: | ||
data: | ||
x: | ||
type: Boolean |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"name": "your-package-name", | ||
"version": "1.0.0", | ||
"main": "index.js", | ||
"dependencies": { | ||
"mesg-js": "^2.0.0" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
module.exports = ({ foo, bar }, { success, error }) => { | ||
if (foo === 'hello' && bar === 'world') { | ||
success({ message: 'Hello world is valid' }) | ||
} else { | ||
error({ error: 'invalid inputs' }) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be better to explicitly use
hash
got fromdeployService()
here. because in future, we'll make service sids to have one-to-many relationships with service hashes.thus,
ServiceByID()
may return multiple versions and maybe in desc order on deploy time but it's not guaranteed that the first hash in the array will be belong to the last publish because two publish commands may run in parallel for the different versions of same service.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if
ServiceByID(**sid**)
is only going to return the last service version andServiceByID(**hash**)
will only return the same version withhash
, then all ok.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
anyway, we're also using
c.service.Definition
so we have to make this call. let's make sure thatServiceByID(hash)
will return the version forhash
in future too andServiceByID(sid)
may return the latest hash.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's the case.
Yep