Split proto service

[antho1404]

A first step to the discussion yesterday about having a proto definition for the service that we use everywhere and that is totally independent of the local environment.

Here I splitted the service into it's own proto definition and update the apis:

• ListServices
• GetService

They return now a ServiceDetail that contains 2 data:

• Status
• Service

I'm not really fan of the naming for the api so feel free to propose something better

[ilgooz]

Really nice, But I'd like to change naming.

Maybe we can create a new dir at protobuf/definition and have service.proto and workflow.proto(in future) there with Service and Workflow type names. Because this way they'll feel generic by not having the coreapi namespace. This is good specially when we create some systemservices and they can use this proto definitions under definition namespace.

And we can have definition.Service inside coreapi.Service this way not coreapi.ServiceDetail. Which is a better name in my thinking.

[antho1404]

Thanks for the feedback, I agree naming was bad. I was able to change few things:

• definitions/service.proto and coreapi/api.proto does not share the same proto package anymore
• service.proto has its own proto package definitions
• api.proto include definitions package and uses now definitions.Service instead of just Service
• Now api.proto can have its own Service message
• New API is Service { Status: enum, Definition: definitions.Service } so we can access like response.service.definition

Only problem with that is definitions/service.proto has to define the go package option go_package = "github.com/mesg-foundation/core/protobuf/definitions"; in order to generate correctly the pb.go file but it also automatically export the service.pb.go in this directory so I added a hack to mv the file after generated in the build-proto.sh

If anyone knows a better solution i would be really happy :)

[NicolasMahe]

Only problem with that is definitions/service.proto has to define the go package option go_package = "github.com/mesg-foundation/core/protobuf/definitions"; in order to generate correctly the pb.go file but it also automatically export the service.pb.go in this directory so I added a hack to mv the file after generated in the build-proto.sh

Fixed in b09e24f

[ilgooz]

I prefer singular name definition instead of definitions

other than that lgtm

[NicolasMahe]

I approve the concept of this PR but i would like definitions to be renamed to definition.
I already did it in this following PR: #852.
So we can merge in whatever way.

[ilgooz]

manual tests are ok 👍