Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ipfs gateway to ipfs.app.mesg.com #868

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Conversation

krhubert
Copy link
Contributor

No description provided.

@antho1404
Copy link
Member

I can't make it work.

Screen Shot 2019-04-11 at 1 38 53 pm

@NicolasMahe
Copy link
Member

@krhubert can you make it work? ipfs seems to not run on the server

@NicolasMahe
Copy link
Member

@krhubert any news?

@krhubert
Copy link
Contributor Author

ipfs is up && running - should be fine now.

➜  core git:(feature/ipfs-gateway) curl -F file=@tools.go http://ipfs.app.mesg.com:5001/api/v0/add 
{"Name":"tools.go","Hash":"Qmb5WZZgYJCNb6Jw588ysKW1X9x8bVR7ktEWxGEHNhnmsv","Size":"416"}

Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to enable https

@krhubert
Copy link
Contributor Author

we discussed enabling https and it's unnecessary for now (ipfs node is public and everyone can download the full content of it so https, in that case, doesn't give anything (expected waisted time on setting SSL)

Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know the reason why the node ipfs was down.
We need to make sure the server is reliable

@krhubert
Copy link
Contributor Author

Do we know the reason why the node ipfs was down.

Yes, not enough memory, I've already increased it

Copy link
Contributor

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer using https anyway because it makes your interaction private with IPFS, even if the uploaded content is public to anyone. We should enable it at some point.

@NicolasMahe NicolasMahe merged commit 267bb0b into dev Apr 17, 2019
@NicolasMahe NicolasMahe deleted the feature/ipfs-gateway branch April 17, 2019 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants