-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service: simplify Logs() & improve docs #888
Conversation
a9042da
to
1032b2f
Compare
* moved Dependency.Logs() logic into Service.Logs(). * removed unneded TestDependencyLogs() test. * simplify logs tests.
1032b2f
to
d116b6c
Compare
I have a question that is related to logs but not blocking for this PR. Seeing this function, I don't see anything that will make the core to 'stop' listening the logs when let's say the user stops the command |
@NicolasMahe goroutine will eventually be closed when these writers closed inside grpc core pkg by the api cancellation. but we should definitely improve it later to close the reader as well. -i'm actually thinking about creating a custom because for now, |
No description provided.