Marketplace move hashVersion #894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tplace-move-hashVersion # Conflicts: # systemservices/marketplace/mesg.yml
|
@mesg-foundation/core ready to review |
krhubert
approved these changes
Apr 19, 2019
ilgooz
approved these changes
Apr 19, 2019
|
@antho1404 do you agree with this modification? |
|
let's rename |
antho1404
reviewed
Apr 22, 2019
| @@ -27,6 +27,9 @@ type Service struct { | |||
| // It represents the service uniquely. | |||
| Hash string `hash:"-"` | |||
|
|
|||
| // HashVersion is the version of the algorithm used to calculate the of the hash | |||
| HashVersion string `hash:"-"` | |||
There was a problem hiding this comment.
I don't think hash:"-" is used anymore but just to keep in consistent, let's pretend it is and in that case the version is required in the hashing
|
Closing in favor of #906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependant on #864.
Closes #861.
This PR move the
hashVersionfrom the manifest data to the service definition. Like this, the core itself can manage the version used to calculate the service's hash.