Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service marketplace: Add check to make duration strictly positive (like in the smart contract) #939

Merged
merged 1 commit into from
May 2, 2019
Merged

Service marketplace: Add check to make duration strictly positive (like in the smart contract) #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion systemservices/marketplace/src/tasks/prepareCreateServiceOffer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default (
// check inputs
const sid = inputs.sid
const duration = new BigNumber(inputs.duration)
assert.ok(duration.isPositive(), 'duration must be strictly positive')
assert.ok(duration.isPositive() && !duration.isZero(), 'duration must be strictly positive')

// check service
const service = await getService(marketplace, sid)
Expand Down