Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/service start stop args #950

Merged
merged 3 commits into from
May 11, 2019
Merged

Fix/service start stop args #950

merged 3 commits into from
May 11, 2019

Conversation

krhubert
Copy link
Contributor

@krhubert krhubert commented May 9, 2019

fix #915

@NicolasMahe
Copy link
Member

NicolasMahe commented May 10, 2019 •
edited
Loading

@krhubert please say that this PR is related to #948 or you forgot the commit of #948

antho1404
antho1404 approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me but yes please add the dependencies for the PR and the issue they solve

@krhubert
Copy link
Contributor Author

@NicolasMahe Sorry it's not related I mess up commits

@antho1404 antho1404 merged commit bceac85 into dev May 11, 2019
@antho1404 antho1404 deleted the fix/service-start-stop-args branch May 11, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilgooz ilgooz ilgooz approved these changes

@antho1404 antho1404 antho1404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service start & stop with no arguments
4 participants
@krhubert @NicolasMahe @antho1404 @ilgooz