Change Execution Attributes #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krhubert
requested review from
NicolasMahe,
ilgooz and
antho1404
and removed request for
NicolasMahe and
ilgooz
antho1404
requested changes
May 29, 2019
NicolasMahe
reviewed
May 29, 2019
Move task input and output validation to api package.
krhubert
force-pushed
the
feature/execurion-db
branch
from
2e6b2a0
to
29b26cb
Compare
krhubert
force-pushed
the
feature/execurion-db
branch
from
7c3c477
to
fbdb38d
Compare
|
The pull request is doing too many things:
|
NicolasMahe
reviewed
May 30, 2019
NicolasMahe
reviewed
May 30, 2019
NicolasMahe
reviewed
May 30, 2019
I agree with @antho1404. This PR should be splitted into a few more specific ones.
EDIT After checking commit by commit, there is only 2 commits (with 2 or 3 others that fix those) that are blocking the whole PR.. If you have done small PRs, 70% of this PR could have already been merged. |
NicolasMahe
approved these changes
May 30, 2019
NicolasMahe
reviewed
May 30, 2019
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
@krhubert could you move those test in sdk package in a new PR?
The code coverage of sdk is really low: https://codecov.io/gh/mesg-foundation/engine/compare/9cf2d0b48817a45110ca0189e74419b232f137d0...f20bddbc143aa30752d4d07be3be95b76060e68a/src/sdk/sdk.go
antho1404
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes mentioned in https://forum.mesg.com/t/execution-db-and-api/280