Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Hash as bytes #124

Merged
merged 6 commits into from
Aug 30, 2019
Merged

Hash as bytes #124

merged 6 commits into from
Aug 30, 2019

Conversation

NicolasMahe
Copy link
Member

@NicolasMahe NicolasMahe commented Aug 29, 2019

Because of mesg-foundation/engine#1270, hashes are now in bytes instead of string over the gRPC API.

Fix https://github.com/mesg-foundation/mesg-js/issues/123

  • update proto
  • generate new typing
  • add helpers to encode and decode from/to base58
  • update custom hash type from string to Uint8Array
  • update codebase

This version is available on npm: mesg-js@4.3.0-beta.1

@NicolasMahe NicolasMahe added this to the next milestone Aug 29, 2019
@NicolasMahe NicolasMahe requested a review from antho1404 August 29, 2019 10:36
@NicolasMahe NicolasMahe self-assigned this Aug 29, 2019
@@ -1,6 +1,6 @@
{
"name": "mesg-js",
"version": "4.3.0-beta",
"version": "4.3.0-beta.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove the version modification on the PR, this will be done when we release

@antho1404 antho1404 merged commit e3ccc01 into master Aug 30, 2019
@antho1404 antho1404 deleted the feature/hash-as-bytes branch August 30, 2019 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hash type from string to bytes
2 participants