Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing permissions to manage root account #15

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

henryde
Copy link
Contributor

@henryde henryde commented Apr 22, 2024

No description provided.

@henryde henryde requested a review from sttomm April 22, 2024 13:46
"iam:GetSAMLProvider",
"iam:CreateRole",
"iam:AttachRolePolicy",
"iam:UpdateAssumeRolePolicy"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d: You only added the permissions mentioned in the ticket. But looking at our docs, we may need to add even more permissions? https://docs.meshcloud.io/docs/meshstack.how-to.integrate-meshplatform-aws-manually.html#set-up-aws-account-2-management

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works with these permissions then how can I figure out if we need more?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly I have no clue ... perhaps the additional rights are only needed in special configs. I just wanted to bring it up, as it is documented like that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not see this PR anymore, as no re-request was triggered for it. I am not sure which way to go. At least adding these permissions already makes it better. But as mentioned before, perhaps we need the other permissions that are in our public docs, too. But would also be fine for me to first go wih this set of permission

@henryde henryde added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit c30f4fd Apr 29, 2024
1 check passed
@henryde henryde deleted the feature/permissions-root-adoption branch April 29, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants