refactor: cleanup code

meshcloud · May 21, 2024 · dc54332 · dc54332
1 parent 4846066
commit dc54332
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/internal/provider/client.go b/internal/provider/client.go
@@ -209,7 +209,7 @@ func (c *MeshStackProviderClient) ReadBuildingBlock(uuid string) (*MeshBuildingB
 	}
 
 	if res.StatusCode != 200 {
-		return nil, errors.New(fmt.Sprintf("unexpected status code: %d, %s", res.StatusCode, data))
+		return nil, fmt.Errorf("unexpected status code: %d, %s", res.StatusCode, data)
 	}
 
 	var bb MeshBuildingBlock
@@ -246,7 +246,7 @@ func (c *MeshStackProviderClient) ReadProject(workspace string, name string) (*M
 	}
 
 	if res.StatusCode != 200 {
-		return nil, errors.New(fmt.Sprintf("unexpected status code: %d, %s", res.StatusCode, data))
+		return nil, fmt.Errorf("unexpected status code: %d, %s", res.StatusCode, data)
 	}
 
 	var project MeshProject
@@ -283,7 +283,7 @@ func (c *MeshStackProviderClient) CreateProject(project *MeshProjectCreate) (*Me
 	}
 
 	if res.StatusCode != 201 {
-		return nil, errors.New(fmt.Sprintf("unexpected status code: %d, %s", res.StatusCode, data))
+		return nil, fmt.Errorf("unexpected status code: %d, %s", res.StatusCode, data)
 	}
 
 	var createdProject MeshProject
@@ -323,7 +323,7 @@ func (c *MeshStackProviderClient) UpdateProject(project *MeshProjectCreate) (*Me
 	}
 
 	if res.StatusCode != 200 {
-		return nil, errors.New(fmt.Sprintf("unexpected status code: %d, %s", res.StatusCode, data))
+		return nil, fmt.Errorf("unexpected status code: %d, %s", res.StatusCode, data)
 	}
 
 	var updatedProject MeshProject
@@ -357,7 +357,7 @@ func (c *MeshStackProviderClient) DeleteProject(workspace string, name string) e
 	}
 
 	if res.StatusCode != 202 {
-		return errors.New(fmt.Sprintf("unexpected status code: %d, %s", res.StatusCode, data))
+		return fmt.Errorf("unexpected status code: %d, %s", res.StatusCode, data)
 	}
 
 	return nil

diff --git a/internal/provider/project_resource.go b/internal/provider/project_resource.go
@@ -214,7 +214,6 @@ func (r *projectResource) Read(ctx context.Context, req resource.ReadRequest, re
 
 	// client data maps directly to the schema so we just need to set the state
 	resp.Diagnostics.Append(resp.State.Set(ctx, project)...)
-	return
 }
 
 // Update updates the resource and sets the updated Terraform state on success.