refactor: pull out duplicate io list schema

meshcloud · Apr 30, 2024 · ef739ae · ef739ae
1 parent d8531df
commit ef739ae
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/examples/provider-install-verification/main.tf b/examples/provider-install-verification/main.tf
@@ -18,6 +18,12 @@ data "meshstack_buildingblock" "test" {
   }
 }
 
+data "meshstack_buildingblock" "test_failed" {
+  metadata = {
+    uuid = "4570f298-1f6a-48d0-8f93-13dac606ceb0"
+  }
+}
+
 output "bb_provider_uuid" {
   value = data.meshstack_buildingblock.test.metadata.definition_uuid
 }
diff --git a/internal/provider/buildingblock_data_source.go b/internal/provider/buildingblock_data_source.go
@@ -28,6 +28,18 @@ func (d *buildingBlockDataSource) Metadata(ctx context.Context, req datasource.M
 }
 
 func (d *buildingBlockDataSource) Schema(ctx context.Context, req datasource.SchemaRequest, resp *datasource.SchemaResponse) {
+	// not sure if it is okay to use this value multiple times
+	ioList := schema.ListNestedAttribute{
+		Computed: true,
+		NestedObject: schema.NestedAttributeObject{
+			Attributes: map[string]schema.Attribute{
+				"key":        schema.StringAttribute{Computed: true},
+				"value":      schema.StringAttribute{Computed: true},
+				"value_type": schema.StringAttribute{Computed: true},
+			},
+		},
+	}
+
 	resp.Schema = schema.Schema{
 		MarkdownDescription: "BuildingBlock data source",
 
@@ -63,16 +75,7 @@ func (d *buildingBlockDataSource) Schema(ctx context.Context, req datasource.Sch
 				Attributes: map[string]schema.Attribute{
 
 					"display_name": schema.StringAttribute{Computed: true},
-					"inputs": schema.ListNestedAttribute{
-						Computed: true,
-						NestedObject: schema.NestedAttributeObject{
-							Attributes: map[string]schema.Attribute{
-								"key":        schema.StringAttribute{Computed: true},
-								"value":      schema.StringAttribute{Computed: true},
-								"value_type": schema.StringAttribute{Computed: true},
-							},
-						},
-					},
+					"inputs":       ioList,
 					"parent_building_blocks": schema.ListNestedAttribute{
 						Computed: true,
 						NestedObject: schema.NestedAttributeObject{
@@ -89,17 +92,8 @@ func (d *buildingBlockDataSource) Schema(ctx context.Context, req datasource.Sch
 				Computed: true,
 				Attributes: map[string]schema.Attribute{
 
-					"status": schema.StringAttribute{Computed: true},
-					"outputs": schema.ListNestedAttribute{
-						Computed: true,
-						NestedObject: schema.NestedAttributeObject{
-							Attributes: map[string]schema.Attribute{
-								"key":        schema.StringAttribute{Computed: true},
-								"value":      schema.StringAttribute{Computed: true},
-								"value_type": schema.StringAttribute{Computed: true},
-							},
-						},
-					},
+					"status":  schema.StringAttribute{Computed: true},
+					"outputs": ioList,
 				},
 			},
 		},