[chore] Viper bug has already been fixed #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per spf13/viper#1161, this issue has already been fixed. `github.com/spf13/viper` is okay to. upgrade at this point. Signed-off-by: Antonette Caldwell <pullmana8@gmail.com>
acald-creator
force-pushed
the
upgrade-viper
branch
from
16cef21
to
8d9cda3
Compare
leecalcote
approved these changes
Nov 28, 2022
|
I might have missed feedback that was given in another venue, but to be sure, I'll ask here: any feedback on this PR, @Revolyssup? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
It would be nice to have this specific dependency away. |
stale
bot
removed
the
issue/stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spf13/viper#1161, this issue has already been fixed.
github.com/spf13/viperis okay to upgrade at this point.Description
This PR fixes #
Notes for Reviewers
Signed commits