-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30 #207
Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30 #207
Conversation
Bumps [github.com/layer5io/meshkit](https://github.com/layer5io/meshkit) from 0.2.29 to 0.2.30. - [Release notes](https://github.com/layer5io/meshkit/releases) - [Commits](meshery/meshkit@v0.2.29...v0.2.30) --- updated-dependencies: - dependency-name: github.com/layer5io/meshkit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
In this PR: meshery/meshkit#117, meshkit now needs newer version of some dependencies. However, controller-runtime seems to be incompatible with client-go v0.21.0 and thus causing operator build failures. Here is some relevant info I found but I'm not sure what would be ideal: @panyuenlau @Utkarsh-pro please look into this. |
go.mod
Outdated
k8s.io/client-go v0.18.12 | ||
k8s.io/api v0.21.0 | ||
k8s.io/apimachinery v0.21.0 | ||
k8s.io/client-go v0.21.0 | ||
sigs.k8s.io/controller-runtime v0.6.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems controller-runtime starts to support Kubernetes v1.21 from v0.9.0-beta.0(see this PR), with this said, we need to update the controller-runtime package to v0.9.0 or later to support the Kubernetes packages upgrade here.
This requires some code changes, for example, the Reconcile() function signature got changed in this PR for v0.7.0 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh I see 👀
Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
@DelusionalOptimist This PR #208 fixes the dependency issue that causes the build failure here, but not sure why the PR doesn't trigger the CI jobs |
Signed-off-by: Rudraksh Pareek <rudrakshpareek3601@gmail.com>
This reverts commit 907aa6c.
…com/layer5io/meshkit-0.2.30
@panyuenlau I merged your PR into this one as you had set the base branch to this originally. |
@DelusionalOptimist Ahhh, I see why: the |
A newer version of github.com/layer5io/meshkit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumping golang to v1.16 and re-running workflows. |
Signed-off-by: leecalcote <leecalcote@gmail.com>
All green lights on the build checks. Merging... |
Bumps github.com/layer5io/meshkit from 0.2.29 to 0.2.30.
Release notes
Sourced from github.com/layer5io/meshkit's releases.
Commits
a18e452
Merge pull request #117 from utkarsh-pro/utkarsh-pro/fix/component-generator-...5d09dd2
change metadata keys to comply with the specification7e6ee2e
Merge pull request #113 from Revolyssup/masterf0e5782
Merge pull request #115 from piyushsingariya/fix/singariya/minor-10f96a6f
minor fix in the logic0378821
added few extra checks to avoid panic7a7188a
added few extra checks to avoid panicDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)