Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handled potential panic in one of the cases in gitwalker #122

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Oct 28, 2021

Signed-off-by: ashish ashishjaitiwari15112000@gmail.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ashish <ashishjaitiwari15112000@gmail.com>
@Revolyssup
Copy link
Contributor Author

Revolyssup commented Oct 28, 2021

@Utkarsh-pro sorry I missed it. Although with current approach in how I am using the function, there is no issue. But with this release, things will be completely stable. We can merge this PR and make the release in some time. Although until then this function should be handled with caution.

Copy link
Contributor

@tangledbytes tangledbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangledbytes tangledbytes merged commit 65a23b9 into meshery:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants