Update biome, fix and enforce recommended rules #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Brandon Vandegrift seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
bmv437
force-pushed
the
feature/enforce-biome
branch
from
a599a32 to
fc7222e
Compare
bmv437
force-pushed
the
feature/enforce-biome
branch
from
fc7222e to
404052f
Compare
Hunter275
added
bug
bmv437
force-pushed
the
feature/enforce-biome
branch
from
404052f to
94cf819
Compare
bmv437
force-pushed
the
feature/enforce-biome
branch
from
94cf819 to
93b139c
Compare
|
I've rebased this PR onto the latest master branch, and applied additional biome fixes to the latest changes. @Hunter275 let me know if you have any questions or concerns. |
|
@bmv437 perfect I’ll work on testing this and merging this weekend |
|
Very excited for this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes in this PR are auto-fixes from running
biome check . --write.Notable changes:
alltorecommended.useToastfrom using auseState+useEffectto auseSyncExternalStoreinstead. This was because Biome showed an error where theuseEffectdid not havelistenersin it's dependencies array. Seeing thatlistenersdidn't actually belong in theuseEffectdependencies, I noticed this was actually a better fit foruseSyncExternalStore.