Skip to content

Commit

Permalink
TST: remove wrong test testing the wrong thing
Browse files Browse the repository at this point in the history
The test tried to test the effect of setting the MACOS_BUILD_TARGET
environment variable on the produced wheel tags, however there is bug
for which the emitted tags are always compared to the tag for the
current platform. The environment variable has no effect on the wheel
tags. Remove the bogus test.
  • Loading branch information
dnicolodi committed Feb 15, 2023
1 parent e0c3d39 commit f4cdce7
Showing 1 changed file with 0 additions and 15 deletions.
15 changes: 0 additions & 15 deletions tests/test_tags.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,18 +93,3 @@ def test_tag_mixed_abi(monkeypatch):
'platlib': [f'extension{ABI3SUFFIX}', f'another{SUFFIX}'],
})
assert str(builder.tag) == f'{INTERPRETER}-{ABI}-{PLATFORM}'


@pytest.mark.skipif(platform.system() != 'Darwin', reason='macOS specific test')
def test_tag_macos_build_target(monkeypatch):
monkeypatch.setenv('MACOS_BUILD_TARGET', '12.0')
builder = wheel_builder_test_factory(monkeypatch, {
'platlib': [f'extension{SUFFIX}'],
})
assert builder.tag.platform == re.sub(r'\d+\.\d+', '12.0', PLATFORM)

monkeypatch.setenv('MACOS_BUILD_TARGET', '10.9')
builder = wheel_builder_test_factory(monkeypatch, {
'platlib': [f'extension{SUFFIX}'],
})
assert builder.tag.platform == re.sub(r'\d+\.\d+', '10.9', PLATFORM)

0 comments on commit f4cdce7

Please sign in to comment.