Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-settings support needs docs #230

Closed
rgommers opened this issue Nov 24, 2022 · 4 comments · Fixed by #276
Closed

config-settings support needs docs #230

rgommers opened this issue Nov 24, 2022 · 4 comments · Fixed by #276
Labels
documentation Improvements or additions to documentation

Comments

@rgommers
Copy link
Contributor

This is a follow-up issue for gh-167. The most important thing to add is docs. The invocations are verbose and argument quoting can be difficult, so we need a good number of one-liners as usage examples (there are some near the bottom of gh-167).

Also, it's possible that there's still an issue with functionality. --config-settings doesn't take multiple arguments at once, so if you'd want to pass multiple arguments to meson setup, it seems like there's no good way to do it. Something like:

python -m pip install . --no-build-isolation --config-settings='setup-args=-Dblas=blas' --config-settings='setup-args=-Dlapack=lapack'

seems to just use one of the two arguments. @tacaswell and I tried for a while, and didn't get it to work. It's possible we missed something.

@rgommers rgommers added the documentation Improvements or additions to documentation label Nov 24, 2022
@eli-schwartz
Copy link
Member

Sounds like maybe the config-settings design is that the backend is responsible for taking a single setup-args=... and doing its own word splitting on the value to convert it from a command line string to a list of arguments?

(For comparison, meson setup -Dopt=val supports array-type values. We handle this as comma-separated values, or optionally also as meson setup -Dopt="['val1', 'val2']".)

@dnicolodi
Copy link
Member

I haven't found this documented any better than here https://peps.python.org/pep-0517/#config-settings where is only very vaguely defined. But this works with build:

python3 -m build -w -n . -Csetup-args=-Doptimization=3 -Csetup-args=-Ddebug=true

thus I think the design is for the option to be repeated. But this brings the questions: why setup-args plural?

@dnicolodi
Copy link
Member

#59 (comment)

@tacaswell
Copy link
Contributor

I missed that this existed and created #235 which has error logs.

FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 27, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Jan 31, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00 added a commit to FFY00/meson-python that referenced this issue Feb 1, 2023
Closes mesonbuild#197, mesonbuild#230, mesonbuild#253, and mesonbuild#264
Sets us up to fix mesonbuild#138, mesonbuild#233, and mesonbuild#224

Signed-off-by: Filipe Laíns <lains@riseup.net>
@FFY00 FFY00 closed this as completed in #276 Feb 1, 2023
FFY00 added a commit that referenced this issue Feb 1, 2023
Closes #197, #230, #253, and #264
Sets us up to fix #138, #233, and #224

Signed-off-by: Filipe Laíns <lains@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants