Sundry fixes around meson setup handling
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnicolodi
force-pushed
the
native-location
branch
from
27e10e7
to
078932f
Compare
Use a 'meson-python-' prefix to likely avoid any possible name collision. As the build directory is supposed to contain build artefact there is no advantage in using an UNIX hidden file name for these files, and this makes them a little bit more discoverable. Fixes mesonbuild#299.
Project._meson() calls Project._proc() that translates failures in running the command into a SystemExit exception.
dnicolodi
force-pushed
the
native-location
branch
from
078932f
to
fc71657
Compare
lithomas1
approved these changes
Feb 13, 2023
Always pass the '--reconfigure' argument to 'meson setup' if the build directory is a valid Meson build directory. Fixes mesonbuild#300.
The native file is not intended to be added to version control, thus it should never have be present in the dist archive prepared by Meson. With it moved to the build directory there is no risk of it ever being present.
dnicolodi
force-pushed
the
native-location
branch
from
fc71657
to
3fa0d33
Compare
|
@FFY00 do you want to have a close look at this (and other recent PRs) or can I merge it? PS: if you still need help with laser goggles and optical filters shoot me an email |
FFY00
reviewed
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.