Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE Provide "User defined options" summary for options set in the native file #13865

Open
evelikov opened this issue Nov 4, 2024 · 0 comments

Comments

@evelikov
Copy link

evelikov commented Nov 4, 2024

Describe the bug

Currently meson produces very nice summary when user has defined any options on the command line. Although it does not list any options that have been set via a native file.

To Reproduce

Grab any meson project and add the following native file:

$ cat native.ini
[project options]
strip = true

Then setup as normal and observe the output:

$ meson setup build/
...
  User defined options
    Native files     : native.ini // only the file and not the options within

Expected behavior

Print the option from the native file, unless overridden. Eg:

$ meson setup build/
 ...
  User defined options
    Native files     : native.ini
        +> strip: true // better visualisation ideas highly appreciated
$ meson setup -D strip=false build/
 ...
  User defined options
    Native files     : native.ini
    // should probably mention that strip is set, but overridden?
    strip            : false
@evelikov evelikov changed the title Provide summary in "User defined options" for options set in the native file set on the command line. For example meson setup --native-file build-dev.ini -D strip=false build/ will produce: User defined options Native files : build-dev.ini strip : false Provide summary in "User defined options" for options set in the native file Nov 4, 2024
@evelikov evelikov changed the title Provide summary in "User defined options" for options set in the native file RFE Provide "User defined options" summary for options set in the native file Nov 4, 2024
lucasdemarchi added a commit to kmod-project/kmod that referenced this issue Nov 7, 2024
This may be useful for anyone trying a non-debug build and serve as
baseline for distros. Even for developers, when benchmarking kmod, it's
better to run a release-oriented kmod rather than the slow one due to
all debug/sanitizers.

By keeping the -D in the command line rather than in a ini file,
we also guarantee meson shows it in the summary, regardless of
mesonbuild/meson#13865.

Closes: #220
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
lucasdemarchi added a commit to kmod-project/kmod that referenced this issue Nov 7, 2024
This may be useful for anyone trying a non-debug build and serve as
baseline for distros. Even for developers, when benchmarking kmod, it's
better to run a release-oriented kmod rather than the slow one due to
all debug/sanitizers.

By keeping the -D in the command line rather than in a ini file,
we also guarantee meson shows it in the summary, regardless of
mesonbuild/meson#13865.

Closes: #220
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: #221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant