Revert "Clarify mutable objects usage" #13386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f02d0a. It turns out that this does introduce a behavioral change in existing users of ConfigurationData, which it wasn't supposed to (it was supposed to preserve behavior there, and add a new *warning* for EnvironmentVariables). This breaks projects such as pulseaudio, libvirt, and probably more. Roll back the change and try again after 1.5.0 is released. Fixes: mesonbuild#13372
|
Bionic job fails due to actions/runner#3373 (comment) Github has broken their runner deployment, basically. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9f02d0a.
It turns out that this does introduce a behavioral change in existing users of ConfigurationData, which it wasn't supposed to (it was supposed to preserve behavior there, and add a new warning for EnvironmentVariables).
This breaks projects such as pulseaudio, libvirt, and probably more. Roll back the change and try again after 1.5.0 is released.
Fixes: #13372
Given this is still not fixed in rc2 and rc3 is imminent, I think we really need to hold off on making this change.
I tried to find time two weeks ago to debug this but didn't, and it's going into the weekend and I won't have any time then either. The original design seems flawed to me but I am not sure how to do it better.
I have spent more time than I really wanted to spend late on a Friday, just pinpointing the exact issue. So at least we have a regression test now. :)