VS: Add support for /utf-8 #13929
Draft
VS: Add support for /utf-8 #13929
+158
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lb90
force-pushed
the
vs-backend-utf8
branch
from
6991a4f
to
7f9ea38
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lb90
force-pushed
the
vs-backend-utf8
branch
2 times, most recently
from
f498add
to
5d9a838
Compare
Some arguments correspond to MSBuild properties ($(VCTargetsPath)\Microsoft.cpp*.props), for example: * /EH: <ExceptionHandling> * /O: <Optimization> * etc. The ones which have no corresponding property must be specified via <AdditionalOptions>.
Otherwise it's going to be modified (e.g in the vs generator)
We're going to add /utf-8 back in subsequent commit
Thisi can be used to add default args. Unlike always args, default args can be overriden.
lb90
force-pushed
the
vs-backend-utf8
branch
from
5d9a838
to
5374e76
Compare
| extra_link_args.pop(index) | ||
| return index is not None | ||
|
|
||
| def check_link_arg_prefix(prefix): |
Check notice
Code scanning / CodeQL
Unused local variable Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
<AdditionalOptions>(under<ClCompile>and<Link>, respectively)Compiler.add_default_args(CompileArgs)method and make all backends (ninja, xcode, vs) honour that. It's used to append Meson default arguments (at last, before the link args) in a transparent manner, so Meson's default arguments can be overriden by the user./utf-8from theMSVCCompiler's always args toVisualStudioLikeCompiler.add_default_args(CompileArgs)MSVCCompiler.get_always_args()returning a reference to its internal data rather than a copyFixes #13860