-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow C# projects to contain multiple file types #8688
base: master
Are you sure you want to change the base?
Conversation
This allows for linking a C# executable against a C++ .NET assembly that was generated in the same project.
This fix is probably too simple, even though it actually fixes my problem... Any thoughts how this could be improved upon? Basically, linking a C# executable against a DLL should not add a C++ compiler to |
At the very least we need a test for this, but I'm not even sure how you output .net assembly from c++ and whether what we really need is a |
With the patch in this PR I managed to compile the C++ .NET assembly and use it successfully from C#: |
I should be able to come up with a test for this, I will do that when I have some time later. |
It looks to me as if the C++ compiler generates a 32-bit dll, but Is there anything I can do to ensure that both produce output for the same architecture? Thanks! |
@dcbaker any thoughts on how to fix the build? Thanks! |
I'll have to think about it some more, i've been putting off getting out my windows machine for a while now, I may have to go ahead and do that. |
Something that surprises me is that vc2017x86ninja appears to be the only build where the C# tests are run, as they are skipped on the other vc build. |
This allows for linking a C# executable against a C++ .NET assembly that was generated in the same project.