Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add setupOptions configuration, useful for passing --cross-file to meson setup #94

Merged
merged 1 commit into from
Aug 4, 2022
Merged

add setupOptions configuration, useful for passing --cross-file to meson setup #94

merged 1 commit into from
Aug 4, 2022

Conversation

chris-laplante
Copy link
Contributor

Partial fix for #46

@Ongy
Copy link
Collaborator

Ongy commented Jul 31, 2022

Can we call this configOptions or configureOptions or similar?

Then it matches the actual command.

@chris-laplante
Copy link
Contributor Author

Can we call this configOptions or configureOptions or similar?

Then it matches the actual command.

meson setup is a command that is used by this plugin. Plus there's already a mesonbuild.configureOptions which corresponds to meson configure (though it's also passed to meson setup for some reason).

@Ongy
Copy link
Collaborator

Ongy commented Aug 1, 2022

I'm dumb, sorry. LGTM

@chris-laplante
Copy link
Contributor Author

chris-laplante commented Aug 1, 2022 •
edited
Loading

I'm dumb, sorry. LGTM

No problem, thanks :)

@dcbaker dcbaker merged commit ba953c1 into mesonbuild:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ongy Ongy Ongy approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-laplante @Ongy @dcbaker