-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make tachyon version configurable #101
Conversation
Thanks - One more issue we've seen is that Tachyon doesn't work when spark-ec2 sets the Hadoop version to 2 in the environment. It'll be great if you could file that as an issue in Tachyon |
LGTM |
Yeah, we have two other Tachyon/spark-ec2 issues on the Spark JIRA: SPARK-3185 and SPARK-5331 |
@uronce-cc One thing that I'm concerned about is that the Spark 1.3 cut has already happened so the spark_ec2.py change will most likely be in Spark 1.4 -- In that case we should probably merge this in the branch-1.4 and not branch-1.3 |
@shivaram In Spark 1.2/1.3, it requires Tachyon 0.5.0. This fix should fix the issue with the current released spark work. When Spark 1.3 is released, is the plan to create a new spark-ec2 branch based on the current branch-1.3? |
@haoyuan When I build the docker image, you told me to support hadoop 1, have hadoop 2 supported yet? |
Ah I see -- Thanks @haoyuan . In that case @uronce-cc could you break up the PR into two parts ? In this PR lets just have Tachyon 0.5, 0.6 added. Once the spark_ec2.py change goes in you can send another PR adding the environment variable. Does that sound good ? |
@shivaram Which Hadoop version does Spark run against by default? The current Tachyon bin tar is built against Hadoop 1.0.4. It is simple to have tar ball against other Hadoop version. |
Spark by default is built with 1.0.4 -- You can add another switch statement based on P.S: Note that Spark for Hadoop Major Version 2 is actually built with CDH 4 (I think CDH 4.2.0) |
@shivaram ok, I'll do the spark_ec2.py task first. |
@shivaram You've meant that this PR should be merged to branch-1.4, but there is no branch-1.4 yet, where shall I submit to? |
We don't have a |
…t script This PR comes from Tachyon community to solve the issue: https://tachyon.atlassian.net/browse/TACHYON-11 An accompanying PR is in mesos/spark-ec2: mesos/spark-ec2#101 Author: cheng chang <myairia@gmail.com> Closes #4901 from uronce-cc/master and squashes the following commits: 313aa36 [cheng chang] minor re-wording fd2a48e [cheng chang] Remove Tachyon when deploying through git hash 1d53c5c [cheng chang] add default value to --tachyon-version 6f8887e [cheng chang] make tachyon version configurable
@shivaram Could you open a branch1.4 in spark-ec2 ? |
Created |
This patch comes from the tachyon community to resolve issue:
https://tachyon.atlassian.net/browse/TACHYON-11
there will be an accompanying patch to spark/ec2 in apache/spark too.