Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tachyon version configurable #101

Closed
wants to merge 1 commit into from
Closed

make tachyon version configurable #101

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 5, 2015

This patch comes from the tachyon community to resolve issue:
https://tachyon.atlassian.net/browse/TACHYON-11

there will be an accompanying patch to spark/ec2 in apache/spark too.

@shivaram
Copy link

shivaram commented Mar 5, 2015

Thanks - One more issue we've seen is that Tachyon doesn't work when spark-ec2 sets the Hadoop version to 2 in the environment. It'll be great if you could file that as an issue in Tachyon

@nchammas
Copy link

nchammas commented Mar 5, 2015

LGTM

@nchammas
Copy link

nchammas commented Mar 5, 2015

Yeah, we have two other Tachyon/spark-ec2 issues on the Spark JIRA: SPARK-3185 and SPARK-5331

@shivaram
Copy link

shivaram commented Mar 5, 2015

@uronce-cc One thing that I'm concerned about is that the Spark 1.3 cut has already happened so the spark_ec2.py change will most likely be in Spark 1.4 -- In that case we should probably merge this in the branch-1.4 and not branch-1.3

@haoyuan
Copy link

haoyuan commented Mar 5, 2015

@shivaram In Spark 1.2/1.3, it requires Tachyon 0.5.0. This fix should fix the issue with the current released spark work.

When Spark 1.3 is released, is the plan to create a new spark-ec2 branch based on the current branch-1.3?

@ghost
Copy link
Author

ghost commented Mar 5, 2015

@haoyuan When I build the docker image, you told me to support hadoop 1, have hadoop 2 supported yet?

@shivaram
Copy link

shivaram commented Mar 5, 2015

Ah I see -- Thanks @haoyuan . In that case @uronce-cc could you break up the PR into two parts ? In this PR lets just have Tachyon 0.5, 0.6 added. Once the spark_ec2.py change goes in you can send another PR adding the environment variable.

Does that sound good ?

@haoyuan
Copy link

haoyuan commented Mar 5, 2015

@shivaram Which Hadoop version does Spark run against by default? The current Tachyon bin tar is built against Hadoop 1.0.4. It is simple to have tar ball against other Hadoop version.

@shivaram
Copy link

shivaram commented Mar 5, 2015

Spark by default is built with 1.0.4 -- You can add another switch statement based on HADOOP_MAJOR_VERSION as it is done in https://github.com/mesos/spark-ec2/blob/branch-1.3/spark/init.sh#L113

P.S: Note that Spark for Hadoop Major Version 2 is actually built with CDH 4 (I think CDH 4.2.0)

@ghost ghost closed this Mar 5, 2015
@ghost
Copy link
Author

ghost commented Mar 5, 2015

@shivaram ok, I'll do the spark_ec2.py task first.

@ghost
Copy link
Author

ghost commented Mar 7, 2015

@shivaram You've meant that this PR should be merged to branch-1.4, but there is no branch-1.4 yet, where shall I submit to?

@shivaram
Copy link

shivaram commented Mar 7, 2015

We don't have a branch-1.4 yet as Spark's master branch version hasn't been updated to 1.4 yet (https://github.com/apache/spark/blob/master/pom.xml#L29) . I think this will happen soon as a release vote is underway -- If not I'll create a branch-1.4 in spark-ec2 in the next couple of days

asfgit pushed a commit to apache/spark that referenced this pull request Mar 10, 2015
…t script

This PR comes from Tachyon community to solve the issue:
https://tachyon.atlassian.net/browse/TACHYON-11

An accompanying PR is in mesos/spark-ec2:
mesos/spark-ec2#101

Author: cheng chang <myairia@gmail.com>

Closes #4901 from uronce-cc/master and squashes the following commits:

313aa36 [cheng chang] minor re-wording
fd2a48e [cheng chang] Remove Tachyon when deploying through git hash
1d53c5c [cheng chang] add default value to --tachyon-version
6f8887e [cheng chang] make tachyon version configurable
@ghost
Copy link
Author

ghost commented Mar 12, 2015

@shivaram Could you open a branch1.4 in spark-ec2 ?

@shivaram
Copy link

Created branch-1.4. I don't have permission to set it as the default branch though
@pwendell could probably help with that

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants