-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/upload local recipes to s3 #189
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 16 16
Lines 476 476
=======================================
Hits 469 469
Misses 7 7 ☔ View full report in Codecov by Sentry. |
This PR focuses on uploading local recipes to S3 and is ready for prioritized merging after review. The database handler import issue has taken longer to resolve than anticipated, so I'll keep working on the Once we all agree on the solution for database handler initiation and all related PRs are merged, I'll resume work on uploading remote recipes to S3 and storing metadata to firebase. Thanks! |
simulariumHelper.open_in_simularium(url) | ||
|
||
@staticmethod | ||
def store_results_to_s3(file_path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might consider moving more of this into the handler. so in this file all you have to do is call url = AWSHandler(OPTIONS).save_file(file_path)
and everything is handled by the other file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I was able to run the specified recipe and it opened up results in a browser tab.
try: | ||
url = simulariumHelper.store_results_to_s3(simularium_file) | ||
except Exception as e: | ||
aws_readme_url = "https://github.com/mesoscope/cellpack/blob/feature/main/README.md#aws-s3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful, thanks for adding it in!
Problem
What is the problem this work solves, including
Partially closing #140
Solution
What I/we did to solve this problem
simularium_helper.py
to:- store local results to S3 path:
cellpack-results/simularium
- enable automatically opened packing results on Simularium
Note: a separate PR will handle the upload of metadata to firebase
Type of change
Please delete options that are not relevant.
Steps to Verify:
pack -r cellpack/tests/recipes/v2/test_spheres.json -c examples/packing-configs/sparse-packing.json
Keyfiles (delete if not relevant):
simularium_helper.py
AWSHandler.py