Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/S3 uploads and new browser tabs handling #203

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

rugeli
Copy link
Collaborator

@rugeli rugeli commented Oct 11, 2023

Problem

What is the problem this work solves, including
our current conditional statement if env.config_data.get("upload_results", env.config_data.get("number_of_packings", 1) <= 1): on main prioritizes checking upload_results with its default value set to False. So the check will be skipped if upload_results is not explicitly set to True in the config file

Solution

What I/we did to solve this problem
changed the if-statement to evaluate upload_results and number_of_packings individually

with @meganrm

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@rugeli rugeli requested review from meganrm and mogres October 11, 2023 21:32
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fee423f) 98.52% compared to head (baf613d) 98.52%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          16       16           
  Lines         476      476           
=======================================
  Hits          469      469           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli rugeli changed the title Fix/check upload results fix/S3 uploads and new browser tabs handling Oct 11, 2023
Copy link
Collaborator

@mogres mogres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Having the upload_results set to False by default would not have worked with the previous check.

@rugeli rugeli merged commit 9105668 into main Oct 12, 2023
7 checks passed
@rugeli rugeli deleted the fix/check-upload-results branch October 12, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants