fix/S3 uploads and new browser tabs handling #203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
our current conditional statement
if env.config_data.get("upload_results", env.config_data.get("number_of_packings", 1) <= 1):
onmain
prioritizes checkingupload_results
with its default value set toFalse
. So the check will be skipped ifupload_results
is not explicitly set toTrue
in the config fileSolution
What I/we did to solve this problem
changed the if-statement to evaluate
upload_results
andnumber_of_packings
individuallywith @meganrm
Type of change
Please delete options that are not relevant.