fix: bundle konvoy-async-plugin in Docker image #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuto
force-pushed
the
cbuto/async-binaries
branch
from
c002080
to
3aad1f3
Compare
cbuto
force-pushed
the
cbuto/async-binaries
branch
2 times, most recently
from
4ad5ef6
to
b7b4727
Compare
cbuto
commented
May 27, 2022
cbuto
force-pushed
the
cbuto/async-binaries
branch
from
b7b4727
to
7fcd688
Compare
mhrabovcin
reviewed
Jun 1, 2022
mhrabovcin
reviewed
Jun 1, 2022
mhrabovcin
reviewed
Jun 1, 2022
mhrabovcin
approved these changes
Jun 1, 2022
cwyl02
reviewed
Jun 1, 2022
cwyl02
approved these changes
Jun 1, 2022
branden
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.d2iq.com/browse/D2IQ-88413
This commit introduces a new make target to download the
konvoy-async-pluginbinaries and place them in the correct directory.I had to fix a few things:
dex-k8s-authenticatorbinary due to cannot find package hcl/hcl/printer hashicorp/hcl#449.dex-k8s-authenticatorbinary out of the Docker image because we rely on private Go modules, so it just easier if we build the binary outside of the Docker image and copy it in.I was able to test this locally using the instructions in
docs/develop.md. The actual HTML templates we use in Kommander are found at https://github.com/mesosphere/charts/tree/master/staging/dex-k8s-authenticator/html-templates.