Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass datacenter #710

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: pass datacenter #710

merged 3 commits into from
Mar 2, 2023

Conversation

faiq
Copy link
Collaborator

@faiq faiq commented Mar 2, 2023

What problem does this PR solve?:
when a user specifies dry-run when building a vm template, govc is unable to delete the image properly due to a missing flag

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@github-actions github-actions bot added the fix label Mar 2, 2023
@faiq faiq requested a review from supershal March 2, 2023 15:14
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

File Coverage
All files 14%
cmd/konvoy-image-wrapper/cmd/wrapper.go 8%
cmd/konvoy-image-wrapper/image/common.go 0%
cmd/konvoy-image-wrapper/image/image_not_embedded.go 0%
pkg/ansible/runner.go 0%
pkg/app/artifacts.go 0%
pkg/app/build.go 0%
pkg/app/build_azure.go 2%
pkg/app/build_gcp.go 0%
pkg/app/config.go 50%
pkg/app/errors.go 0%
pkg/app/provision.go 0%
pkg/app/root.go 0%
pkg/app/utils.go 7%
pkg/app/validate.go 0%
pkg/appansible/io.go 0%
pkg/appansible/playbook.go 0%
pkg/azure/azure.go 0%
pkg/logging/logger.go 0%
pkg/packer/manifest.go 0%
pkg/packer/packer.go 0%
pkg/stringutil/rand.go 0%
pkg/version/info.go 8%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against 6b262e6

Copy link
Collaborator

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release-vsphere-template.yaml Outdated Show resolved Hide resolved
.github/workflows/vsphere-e2e.yaml Show resolved Hide resolved
@supershal
Copy link
Collaborator

Please fix it in https://github.com/mesosphere/konvoy-image-builder/blob/main/.github/workflows/release-vsphere-template.yaml too.

Release job wont delete the template. This change is not needed.

@faiq faiq merged commit eb54427 into main Mar 2, 2023
@faiq faiq deleted the faiq/fix-govc branch March 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants